[Lldb-commits] [PATCH] D67520: Add pretty printing of Clang "bitfield" enums

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

The code looks fine to me.



================
Comment at: source/Symbol/ClangASTContext.cpp:9502
+    ++num_enumerators;
+    if (val == enum_svalue) {
+      s->PutCString(enumerator->getNameAsString());
----------------
Can you put a comment here like:

// TADA - we found the exact value, print it.

It took me a bit to figure out where the normal path of printing an enum that had a simple enum value went...




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67520/new/

https://reviews.llvm.org/D67520