[Lldb-commits] [PATCH] D67111: Adding caching to libc++ std::function formatter for lookups that require scanning symbols

Frederic Riss via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Sep 11 08:18:32 PDT 2019


friss accepted this revision.
friss added a comment.
This revision is now accepted and ready to land.

This LGTM, in principle, but it's weird to add the testing in a skipped test. I trust that it works on your machine, but we won't know if it works on all the tested configurations. Can committing this wait for the perf issue to be fixed? Do you know how much work this is going to be?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67111/new/

https://reviews.llvm.org/D67111





More information about the lldb-commits mailing list