[Lldb-commits] [PATCH] D67376: [DWARF] Evaluate DW_OP_entry_value

[Vedant Kumar via Phabricator via lldb-commits]

vsk planned changes to this revision.
vsk marked an inline comment as done.
vsk added a comment.

While tightening up the test case I think I found an issue with the way inlined frames are handled. I need to take a closer look.



================
Comment at: lldb/include/lldb/Symbol/Function.h:258
+
+using CallSiteParameterArray = std::unique_ptr<std::vector<CallSiteParameter>>;
+
----------------
grandinj wrote:
> the way this is being used seems to indicate it can be 
>    std::vector<CallSiteParameter>
> no need for unique_ptr
That's a totally fair point. The reason I've used unique_ptr here is to save space in CallEdge in the common case, where no call site information is loaded for the function. Call site info is lazily parsed, so we'd like to take a minimal memory hit for functions that aren't in a backtrace.

Also, note that using a pointer allows for a further PointerIntPair memory optimization mentioned below.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67376/new/

https://reviews.llvm.org/D67376