[Lldb-commits] [PATCH] D67378: [Utility] Replace Cleanup by llvm::scope_exit

[Jim Ingham via Phabricator via lldb-commits]

jingham added inline comments.


================
Comment at: lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp:901-902
     // Make sure we deallocate the buffer memory:
-    buffer_cleanup.emplace([process, buffer_addr] { 
-        process->DeallocateMemory(buffer_addr); 
-    });
+    buffer_cleanup.emplace(
+        [process, buffer_addr] { process->DeallocateMemory(buffer_addr); });
   }
----------------
This seems an undesirable cleanup.  Now it is going to be hard to just put a breakpoint on the cleanup code, which seems worth the one extra line (and not related to replacing CleanUp with scope_exit.  Ditto the one on 826.  Is clang-format doing this for you?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67378/new/

https://reviews.llvm.org/D67378