[Lldb-commits] [PATCH] D47629: [DWARF] Add (empty) DebugNamesDWARFIndex class and a setting to control its use

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:122
+PropertyDefinition g_experimental_properties[] = {
+    {"use-debug-names", OptionValue::eTypeBoolean, true, 0, nullptr, nullptr,
+     "Use .debug_names index section."},
----------------
Would it be better to use an inverse setting like "always-manually-index"? That way if there is something wrong with any of the indexes that are generated, then we can fall back to manually indexing? Otherwise we will need to remove this later.


https://reviews.llvm.org/D47629