[Lldb-commits] [PATCH] D31129: Remove remaining platform specific code from FileSpec

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 20 04:02:45 PDT 2017

labath added inline comments.

Comment at: lldb/include/lldb/Utility/TildeExpressionResolver.h:62
+class MockTildeExpressionResolver : public TildeExpressionResolver {
+  llvm::StringRef CurrentUser;
I find it very strange to see the Mock object in a regular header file (and I also don't see a reason why we would need that). Could we get rid of this? (perhaps by declaring it in a test-only header file if necessary)


More information about the lldb-commits mailing list