[Lldb-commits] [PATCH] D31129: Remove remaining platform specific code from FileSpec

[Zachary Turner via lldb-commits]

The reason was because two different tests from two different unittest
executables need it, but we have no good way to share code across unittests
like this. Open to suggestions though
On Mon, Mar 20, 2017 at 4:02 AM Pavel Labath via Phabricator <
reviews at reviews.llvm.org> wrote:

> labath added inline comments.
>
>
> ================
> Comment at: lldb/include/lldb/Utility/TildeExpressionResolver.h:62
> +
> +class MockTildeExpressionResolver : public TildeExpressionResolver {
> +  llvm::StringRef CurrentUser;
> ----------------
> I find it very strange to see the Mock object in a regular header file
> (and I also don't see a reason why we would need that). Could we get rid of
> this? (perhaps by declaring it in a test-only header file if necessary)
>
>
> https://reviews.llvm.org/D31129
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170320/542519f1/attachment.html>