[Lldb-commits] [PATCH] D31086: Remove FileSystem::MakeDirectory

Stephane Sezer via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 20 11:53:34 PDT 2017

sas added a comment.

In https://reviews.llvm.org/D31086#705159, @labath wrote:

> In https://reviews.llvm.org/D31086#704518, @sas wrote:
> > The second behavioral change seems good but the first thing you described is a bit odd. Creating folders with 770 does not seem like a common behavior, and 700 or 755 is usually more standard.
> Don't forget that the real permissions will also reflect the user's `umask(2)`. The completely standard way would be to use 777 or 666 for the permissions (except perhaps for some temporary/sensitive files), and then let the user choose what are the real permissions he wants by setting umask in his bashrc. I guess we are being a bit paranoid here and disallowing the "others" permissions just in case...

Didn't know that. If these respect the user's `umask(2)` then this is good.



More information about the lldb-commits mailing list