[Lldb-commits] [PATCH] D22213: [test] Fix category-based skipping

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 11 04:46:06 PDT 2016

labath created this revision.
labath added a reviewer: tfiala.
labath added a subscriber: lldb-commits.

LLDBTestResult.hardMarkAsSkipped marked the whole class as skipped when the first class in the
test failed the category check. This meant that subsequent tests in the same class did not run
even if they were passing the category filter. Fix that.



Index: packages/Python/lldbsuite/test/test_result.py
--- packages/Python/lldbsuite/test/test_result.py
+++ packages/Python/lldbsuite/test/test_result.py
@@ -113,8 +113,6 @@
     def hardMarkAsSkipped(self,test):
         getattr(test, test._testMethodName).__func__.__unittest_skip__ = True
         getattr(test, test._testMethodName).__func__.__unittest_skip_why__ = "test case does not fall in any category of interest for this run"
-        test.__class__.__unittest_skip__ = True
-        test.__class__.__unittest_skip_why__ = "test case does not fall in any category of interest for this run"
     def startTest(self, test):
         if configuration.shouldSkipBecauseOfCategories(self.getCategoriesForTest(test)):

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D22213.63487.patch
Type: text/x-patch
Size: 792 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160711/4340339c/attachment.bin>

More information about the lldb-commits mailing list