[Lldb-commits] [lldb] r245765 - Revert "Implement basic DidAttach and DidLaunch for DynamicLoaderWindowsDYLD."

[Zachary Turner via lldb-commits]

Author: zturner
Date: Fri Aug 21 18:57:25 2015
New Revision: 245765

URL: http://llvm.org/viewvc/llvm-project?rev=245765&view=rev
Log:
Revert "Implement basic DidAttach and DidLaunch for DynamicLoaderWindowsDYLD."

This reverts commit 7749a10ddbe22767d0e055753c674fcde7f28d39.

This commit introduces about 15-20 new test failures with windows local
targets.

Modified:
    lldb/trunk/source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp

Modified: lldb/trunk/source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp?rev=245765&r1=245764&r2=245765&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp (original)
+++ lldb/trunk/source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp Fri Aug 21 18:57:25 2015
@@ -9,7 +9,6 @@
 
 #include "DynamicLoaderWindowsDYLD.h"
 
-#include "lldb/Core/Log.h"
 #include "lldb/Core/PluginManager.h"
 #include "lldb/Target/Process.h"
 #include "lldb/Target/Target.h"
@@ -73,38 +72,11 @@ DynamicLoaderWindowsDYLD::CreateInstance
 void
 DynamicLoaderWindowsDYLD::DidAttach()
 {
-    Log *log(GetLogIfAnyCategoriesSet(LIBLLDB_LOG_DYNAMIC_LOADER));
-    if (log)
-        log->Printf("DynamicLoaderWindowsDYLD::%s()", __FUNCTION__);
-
-    DidLaunch();
-
-    m_process->LoadModules();
 }
 
 void
 DynamicLoaderWindowsDYLD::DidLaunch()
 {
-    Log *log(GetLogIfAnyCategoriesSet(LIBLLDB_LOG_DYNAMIC_LOADER));
-    if (log)
-        log->Printf("DynamicLoaderWindowsDYLD::%s()", __FUNCTION__);
-
-    ModuleSP executable = GetTargetExecutable();
-
-    if (!executable.get())
-        return;
-
-    ModuleList module_list;
-    module_list.Append(executable);
-    // FIXME: We probably should not always use 0 as the load address
-    // here. Testing showed that when debugging a process that we start
-    // ourselves, there's no randomization of the load address of the
-    // main module, therefore an offset of 0 will be valid.
-    // If we attach to an already running process, this is probably
-    // going to be wrong and we'll have to get the load address somehow.
-    UpdateLoadedSections(executable, LLDB_INVALID_ADDRESS, 0);
-
-    m_process->GetTarget().ModulesDidLoad(module_list);
 }
 
 Error