[Lldb-commits] [PATCH] D12115: [LLDB-MI] Fix -data-info-line when Windows filenames are used.
Zachary Turner via lldb-commits
lldb-commits at lists.llvm.org
Tue Aug 18 16:02:55 PDT 2015
Are you saying that there is a situation where you are given a path, and
you have no idea whether it is a posix path or a windows path? That seems
strange to me. Surely you must know (or be able to find out) if the
computer you are interfacing with is running Windows or non-Windows, right?
On Tue, Aug 18, 2015 at 3:58 PM Dawn Perchik <dawn+llvm at burble.org> wrote:
> dawn added a comment.
> In http://reviews.llvm.org/D12115#226962, @zturner wrote:
> > Rather than all of this ugly error-prone code, can we instead use
> > llvm::sys::fs::root_name to check whether the path contains a drive
> Sadly no, because root_name only parses c:\ correctly if the platform is
> Windows. Our IDE is hosted on Windows but talks to lldb running on OSX.
> I've had this path problem with the DWARF reader and FileSpec - lldb has a
> core assumption that you only want to support Windows paths if you run on
> Windows. At least with FileSpec you can pass a PathSyntax, but you have to
> choose either Windows or Posix, not both. We want to support both Posix
> and Windows style paths. I've not come up with a clean patch for this
> problem so none have been submitted. We should start another thread about
> how to resolve this problem...
> For now, would it be OK to put a FIXME comment in the source?
> rL LLVM
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the lldb-commits