[flang-commits] [PATCH] D138663: [flang][test] Adjust Driver/pass-plugin-not-found.f90 error message

[Rainer Orth via Phabricator via flang-commits]

ro created this revision.
ro added a reviewer: awarzynski.
ro added a project: Flang.
Herald added subscribers: jdoerfert, pengfei, fedor.sergeev.
Herald added a project: All.
ro requested review of this revision.

The `Driver/pass-plugin-not-found.f90` test `FAIL`s on Solaris since part of the error message differs from what the test expects: Solaris has

  error: unable to load plugin 'X.Y': 'Could not load library 'X.Y': ld.so.1: flang-new: X.Y: open failed: No such file or directory'

while the test expects

  error: unable to load plugin 'X.Y': 'Could not load library 'X.Y': X.Y: cannot open shared object file: No such file or directory'

The last part is emitted by the system `dlerror` and is thus unportable.  Hopefully the error test itself is the same everywhere.

The following patch adjusts the expected message accordingly.

Tested on `x86_64-pc-linux-gnu` and `amd64-pc-solaris2.11`.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D138663

Files:
  flang/test/Driver/pass-plugin-not-found.f90


Index: flang/test/Driver/pass-plugin-not-found.f90
===================================================================
--- flang/test/Driver/pass-plugin-not-found.f90
+++ flang/test/Driver/pass-plugin-not-found.f90
@@ -5,4 +5,5 @@
 ! RUN: not %flang -fpass-plugin=X.Y %s 2>&1 | FileCheck %s --check-prefix=ERROR
 ! RUN: not %flang_fc1 -emit-llvm -o /dev/null -fpass-plugin=X.Y %s 2>&1 | FileCheck %s --check-prefix=ERROR
 
-! ERROR: error: unable to load plugin 'X.Y': 'Could not load library 'X.Y': X.Y: cannot open shared object file: No such file or directory'
+! The exact wording of the error message depends on the system dlerror.
+! ERROR: error: unable to load plugin 'X.Y': 'Could not load library 'X.Y': {{.*}}: No such file or directory'


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138663.477758.patch
Type: text/x-patch
Size: 749 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/flang-commits/attachments/20221124/00cd5094/attachment-0001.bin>