[flang-commits] [PATCH] D138190: [flang] Lower ArrayRef to hlfir.designate

[Jean Perier via Phabricator via flang-commits]

jeanPerier marked 2 inline comments as done.
jeanPerier added inline comments.


================
Comment at: flang/lib/Lower/ConvertExprToHLFIR.cpp:71
+    fir::FortranVariableOpInterface base;
+    llvm::SmallVector<hlfir::DesignateOp::Subscript> subscripts;
+    mlir::Value resultShape;
----------------
vzakhari wrote:
> I guess you may use `LoweredSubscripts` here.
Actually the alias is not really needed anymore since it is only used here, I forgot to remove it. But I updated this SmallVector to use a static size, thanks for the tip.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138190/new/

https://reviews.llvm.org/D138190