[flang-commits] [PATCH] D138121: [flang] Add hlfir.designate definition

[Jean Perier via Phabricator via flang-commits]

jeanPerier added a comment.

In D138121#3930956 <https://reviews.llvm.org/D138121#3930956>, @PeteSteinfeld wrote:

> Things build OK and generally look good, but when I run tests, I get failures in the tests for .../HLFIR/designate.fir and .../HLFIR/invalid.fir.

Thanks @PeteSteinfeld, that should be fixed now. I did not set the expected output rank to 0 when there is not component ref and the base is not an array. Serves me right for not initializing my variables.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138121/new/

https://reviews.llvm.org/D138121