[flang-commits] [PATCH] D137634: [flang][RFC] Do not rely on attributes to tag HLFIR variable uses

[Kiran Chandramohan via Phabricator via flang-commits]

kiranchandramohan added a comment.

While for the near term, hlfir.declare will simplify the OpenMP privatisation clause handling but when we bring in the privatisation clauses to the OpenMP dialect, the dialect will have to live with multiple variable types (hlfir.declare, fir.declare, fir.alloca, llvm.alloca etc).



================
Comment at: flang/docs/HighLevelFIR.md:96
+contiguity of fir.box can be deduced in certain case from the hlfir.declare,
+and if the hlfir.declare cannot be found, the transformation passe will have to
+assume that the variable may be non-contiguous.
----------------
Nit: passe -> passes/pass.


================
Comment at: flang/docs/HighLevelFIR.md:114
 
+The hlfir.declare will have a sibling fir.declare operation in FIR that will
+allow keeping variable information until debug info is generated. The main
----------------
Will these two co-exist? Or will `fir.declare`  be generated from `hlfir.declare` ? 


================
Comment at: flang/docs/HighLevelFIR.md:125
 Note that Fortran variables are not necessarily named objects, they can also be
-the result of function references returning POINTERs. fir.declare will also
+the result of function references returning POINTERs. hfir.declare will also
 accept such variables to be described in the IR (a unique name will be built
----------------
fir.declare or hlfir.declare?


================
Comment at: flang/docs/HighLevelFIR.md:1337
+
+Instead of restricting what memory types an HLFIR variable it was considered to
+force the defining operation of HLFIR variable SSA values to always be
----------------
Something is missing in this sentence.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137634/new/

https://reviews.llvm.org/D137634