[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

Fri Oct 11 03:51:43 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `clang-aarch64-sve-vla-2stage` running on `linaro-g3-02` while building `clang,compiler-rt` at step 6 "build stage 1".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/41/builds/2691

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (build stage 1) failure: 'ninja' (failure)
...
[566/655] Building ASM object compiler-rt/lib/orc/CMakeFiles/RTOrc.aarch64.dir/elfnix_tls.x86-64.S.o
[567/655] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.aarch64.dir/xray_log_interface.cpp.o
[568/655] Linking CXX static library /home/tcwg-buildbot/worker/clang-aarch64-sve-vla-2stage/stage1/lib/clang/20/lib/aarch64-unknown-linux-gnu/libclang_rt.ubsan_minimal.a
[569/655] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.aarch64.dir/xray_init.cpp.o
/home/tcwg-buildbot/worker/clang-aarch64-sve-vla-2stage/llvm/compiler-rt/lib/xray/xray_init.cpp:213:27: warning: comparison of integers of different signs: 'int32_t' (aka 'int') and 'size_t' (aka 'unsigned long') [-Wsign-compare]
  213 |   if (ObjId <= 0 || ObjId >= __xray_num_objects()) {
      |                     ~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~
1 warning generated.
[570/655] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-aarch64.dir/tsan_mman.cpp.o
[571/655] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.aarch64.dir/xray_interface.cpp.o
FAILED: compiler-rt/lib/xray/CMakeFiles/RTXray.aarch64.dir/xray_interface.cpp.o 
/home/tcwg-buildbot/worker/clang-aarch64-sve-vla-2stage/stage1/./bin/clang++ --target=aarch64-unknown-linux-gnu -DSANITIZER_COMMON_NO_REDEFINE_BUILTINS -DXRAY_HAS_EXCEPTIONS=1 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/tcwg-buildbot/worker/clang-aarch64-sve-vla-2stage/llvm/compiler-rt/lib/xray/.. -I/home/tcwg-buildbot/worker/clang-aarch64-sve-vla-2stage/llvm/compiler-rt/lib/xray/../../include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wall -Wno-unused-parameter -O3 -DNDEBUG -std=c++17 -march=armv8-a -fPIC -fno-builtin -fno-exceptions -fomit-frame-pointer -funwind-tables -fno-stack-protector -fno-sanitize=safe-stack -fvisibility=hidden -fno-lto -Wthread-safety -Wthread-safety-reference -Wthread-safety-beta -O3 -gline-tables-only -Wno-gnu -Wno-variadic-macros -Wno-c99-extensions -ftrivial-auto-var-init=pattern -Wno-format -fno-rtti -MD -MT compiler-rt/lib/xray/CMakeFiles/RTXray.aarch64.dir/xray_interface.cpp.o -MF compiler-rt/lib/xray/CMakeFiles/RTXray.aarch64.dir/xray_interface.cpp.o.d -o compiler-rt/lib/xray/CMakeFiles/RTXray.aarch64.dir/xray_interface.cpp.o -c /home/tcwg-buildbot/worker/clang-aarch64-sve-vla-2stage/llvm/compiler-rt/lib/xray/xray_interface.cpp
/home/tcwg-buildbot/worker/clang-aarch64-sve-vla-2stage/llvm/compiler-rt/lib/xray/xray_interface.cpp:16:10: fatal error: 'llvm/Support/ErrorHandling.h' file not found
   16 | #include "llvm/Support/ErrorHandling.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
[572/655] Building ASM object compiler-rt/lib/orc/CMakeFiles/RTOrc.aarch64.dir/elfnix_tls.ppc64.S.o
[573/655] Linking CXX shared library /home/tcwg-buildbot/worker/clang-aarch64-sve-vla-2stage/stage1/lib/clang/20/lib/aarch64-unknown-linux-gnu/libclang_rt.ubsan_minimal.so
[574/655] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-aarch64.dir/tsan_rtl.cpp.o
[575/655] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-dynamic-aarch64.dir/tsan_rtl.cpp.o
[576/655] Building CXX object compiler-rt/lib/fuzzer/CMakeFiles/RTfuzzer_interceptors.aarch64.dir/FuzzerInterceptors.cpp.o
[577/655] Building CXX object compiler-rt/lib/orc/CMakeFiles/RTOrc.aarch64.dir/debug.cpp.o
[578/655] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-dynamic-aarch64.dir/tsan_rtl_report.cpp.o
[579/655] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-aarch64.dir/tsan_rtl_report.cpp.o
[580/655] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-dynamic-aarch64.dir/tsan_mman.cpp.o
[581/655] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXrayBASIC.aarch64.dir/xray_basic_logging.cpp.o
[582/655] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.aarch64.dir/xray_buffer_queue.cpp.o
[583/655] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-aarch64.dir/tsan_interface_atomic.cpp.o
[584/655] Building CXX object compiler-rt/lib/hwasan/CMakeFiles/RTHwasan.aarch64.dir/hwasan_interceptors.cpp.o
[585/655] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-dynamic-aarch64.dir/tsan_interface_atomic.cpp.o
[586/655] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.aarch64.dir/xray_utils.cpp.o
[587/655] Building CXX object compiler-rt/lib/fuzzer/CMakeFiles/RTfuzzer.aarch64.dir/FuzzerExtFunctionsWeak.cpp.o
[588/655] Building CXX object compiler-rt/lib/hwasan/CMakeFiles/RTHwasan_dynamic.aarch64.dir/hwasan_interceptors.cpp.o
[589/655] Building CXX object compiler-rt/lib/fuzzer/CMakeFiles/RTfuzzer_main.aarch64.dir/FuzzerMain.cpp.o
[590/655] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXrayPROFILING.aarch64.dir/xray_profiling.cpp.o
[591/655] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXrayPROFILING.aarch64.dir/xray_profile_collector.cpp.o
[592/655] Building CXX object compiler-rt/lib/fuzzer/CMakeFiles/RTfuzzer.aarch64.dir/FuzzerSHA1.cpp.o
[593/655] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-aarch64.dir/tsan_rtl_access.cpp.o
[594/655] Building CXX object compiler-rt/lib/fuzzer/CMakeFiles/RTfuzzer.aarch64.dir/FuzzerIOPosix.cpp.o
[595/655] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-dynamic-aarch64.dir/tsan_rtl_access.cpp.o
[596/655] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXrayFDR.aarch64.dir/xray_fdr_logging.cpp.o
[597/655] Building CXX object compiler-rt/lib/orc/CMakeFiles/RTOrc.aarch64.dir/dlfcn_wrapper.cpp.o
[598/655] Building CXX object compiler-rt/lib/fuzzer/CMakeFiles/RTfuzzer.aarch64.dir/FuzzerUtilLinux.cpp.o
[599/655] Building CXX object compiler-rt/lib/orc/CMakeFiles/RTOrc.aarch64.dir/run_program_wrapper.cpp.o
[600/655] Building CXX object compiler-rt/lib/fuzzer/CMakeFiles/RTfuzzer.aarch64.dir/FuzzerCrossOver.cpp.o
[601/655] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/RTScudoStandaloneCxxWrappers.aarch64.dir/wrappers_cpp.cpp.o
[602/655] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/clang_rt.scudo_standalone_cxx-aarch64.dir/wrappers_cpp.cpp.o
[603/655] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/clang_rt.scudo_standalone-dynamic-aarch64.dir/wrappers_cpp.cpp.o
[604/655] Building CXX object compiler-rt/lib/fuzzer/CMakeFiles/RTfuzzer.aarch64.dir/FuzzerUtilPosix.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/90959