[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

Fri Oct 11 03:41:57 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `clang-ppc64le-rhel` running on `ppc64le-clang-rhel-test` while building `clang,compiler-rt` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/145/builds/2416

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
14.168 [24/46/460] Building CXX object compiler-rt/lib/orc/CMakeFiles/RTOrc.powerpc64le.dir/log_error_to_stderr.cpp.o
14.185 [24/45/461] Building C object compiler-rt/lib/profile/CMakeFiles/clang_rt.profile-powerpc64le.dir/InstrProfilingWriter.c.o
14.195 [24/44/462] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXrayFDR.powerpc64le.dir/xray_fdr_flags.cpp.o
14.226 [24/43/463] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.powerpc64le.dir/xray_flags.cpp.o
14.278 [24/42/464] Building C object compiler-rt/lib/profile/CMakeFiles/clang_rt.profile-powerpc64le.dir/GCDAProfiling.c.o
14.315 [24/41/465] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-powerpc64le.dir/tsan_mman.cpp.o
14.336 [24/40/466] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXrayPROFILING.powerpc64le.dir/xray_profiling_flags.cpp.o
14.338 [24/39/467] Building ASM object compiler-rt/lib/xray/CMakeFiles/RTXray.powerpc64le.dir/xray_trampoline_powerpc64_asm.S.o
14.350 [24/38/468] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.powerpc64le.dir/xray_log_interface.cpp.o
14.383 [24/37/469] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.powerpc64le.dir/xray_init.cpp.o
FAILED: compiler-rt/lib/xray/CMakeFiles/RTXray.powerpc64le.dir/xray_init.cpp.o 
/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/build/./bin/clang++ --target=powerpc64le-unknown-linux-gnu -DSANITIZER_COMMON_NO_REDEFINE_BUILTINS -DXRAY_HAS_EXCEPTIONS=1 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/compiler-rt/lib/xray/.. -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/compiler-rt/lib/xray/../../include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wall -Werror -Wno-unused-parameter -O3 -DNDEBUG -std=c++17 -m64 -fno-function-sections -fPIC -fno-builtin -fno-exceptions -fomit-frame-pointer -funwind-tables -fno-stack-protector -fno-sanitize=safe-stack -fvisibility=hidden -fno-lto -Wthread-safety -Wthread-safety-reference -Wthread-safety-beta -O3 -gline-tables-only -Wno-gnu -Wno-variadic-macros -Wno-c99-extensions -Wno-format -fno-rtti -MD -MT compiler-rt/lib/xray/CMakeFiles/RTXray.powerpc64le.dir/xray_init.cpp.o -MF compiler-rt/lib/xray/CMakeFiles/RTXray.powerpc64le.dir/xray_init.cpp.o.d -o compiler-rt/lib/xray/CMakeFiles/RTXray.powerpc64le.dir/xray_init.cpp.o -c /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/compiler-rt/lib/xray/xray_init.cpp
/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/compiler-rt/lib/xray/xray_init.cpp:213:27: error: comparison of integers of different signs: 'int32_t' (aka 'int') and 'size_t' (aka 'unsigned long') [-Werror,-Wsign-compare]
  213 |   if (ObjId <= 0 || ObjId >= __xray_num_objects()) {
      |                     ~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~
1 error generated.
14.390 [24/36/470] Building C object compiler-rt/lib/profile/CMakeFiles/clang_rt.profile-powerpc64le.dir/InstrProfilingValue.c.o
14.414 [24/35/471] Building C object compiler-rt/lib/profile/CMakeFiles/clang_rt.profile-powerpc64le.dir/InstrProfilingFile.c.o
14.499 [24/34/472] Building CXX object compiler-rt/lib/orc/CMakeFiles/RTOrc.powerpc64le.dir/debug.cpp.o
14.559 [24/33/473] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.powerpc64le.dir/xray_interface.cpp.o
FAILED: compiler-rt/lib/xray/CMakeFiles/RTXray.powerpc64le.dir/xray_interface.cpp.o 
/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/build/./bin/clang++ --target=powerpc64le-unknown-linux-gnu -DSANITIZER_COMMON_NO_REDEFINE_BUILTINS -DXRAY_HAS_EXCEPTIONS=1 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/compiler-rt/lib/xray/.. -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/compiler-rt/lib/xray/../../include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wall -Werror -Wno-unused-parameter -O3 -DNDEBUG -std=c++17 -m64 -fno-function-sections -fPIC -fno-builtin -fno-exceptions -fomit-frame-pointer -funwind-tables -fno-stack-protector -fno-sanitize=safe-stack -fvisibility=hidden -fno-lto -Wthread-safety -Wthread-safety-reference -Wthread-safety-beta -O3 -gline-tables-only -Wno-gnu -Wno-variadic-macros -Wno-c99-extensions -Wno-format -fno-rtti -MD -MT compiler-rt/lib/xray/CMakeFiles/RTXray.powerpc64le.dir/xray_interface.cpp.o -MF compiler-rt/lib/xray/CMakeFiles/RTXray.powerpc64le.dir/xray_interface.cpp.o.d -o compiler-rt/lib/xray/CMakeFiles/RTXray.powerpc64le.dir/xray_interface.cpp.o -c /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/compiler-rt/lib/xray/xray_interface.cpp
/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/compiler-rt/lib/xray/xray_interface.cpp:16:10: fatal error: 'llvm/Support/ErrorHandling.h' file not found
   16 | #include "llvm/Support/ErrorHandling.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
14.565 [24/32/474] Building CXX object compiler-rt/lib/asan/CMakeFiles/RTAsan_dynamic.powerpc64le.dir/asan_allocator.cpp.o
14.613 [24/31/475] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-powerpc64le.dir/tsan_rtl_report.cpp.o
14.669 [24/30/476] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.powerpc64le.dir/xray_powerpc64.cpp.o
14.701 [24/29/477] Building ASM object compiler-rt/lib/orc/CMakeFiles/RTOrc.powerpc64le.dir/elfnix_tls.x86-64.S.o
14.737 [24/28/478] Building ASM object compiler-rt/lib/orc/CMakeFiles/RTOrc.powerpc64le.dir/elfnix_tls.aarch64.S.o
14.811 [24/27/479] Building ASM object compiler-rt/lib/orc/CMakeFiles/RTOrc.powerpc64le.dir/elfnix_tls.ppc64.S.o
14.889 [24/26/480] Building CXX object compiler-rt/lib/asan/CMakeFiles/RTAsan.powerpc64le.dir/asan_allocator.cpp.o
15.124 [24/25/481] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.powerpc64le.dir/xray_buffer_queue.cpp.o
15.399 [24/24/482] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-dynamic-powerpc64le.dir/tsan_rtl.cpp.o
15.534 [24/23/483] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-dynamic-powerpc64le.dir/tsan_rtl_report.cpp.o
15.606 [24/22/484] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/clang_rt.scudo_standalone-powerpc64le.dir/wrappers_c.cpp.o
15.747 [24/21/485] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.powerpc64le.dir/xray_utils.cpp.o
15.791 [24/20/486] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXrayFDR.powerpc64le.dir/xray_fdr_logging.cpp.o
16.210 [24/19/487] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-dynamic-powerpc64le.dir/tsan_interface_atomic.cpp.o
16.218 [24/18/488] Building CXX object compiler-rt/lib/orc/CMakeFiles/RTOrc.powerpc64le.dir/dlfcn_wrapper.cpp.o
16.220 [24/17/489] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/RTScudoStandaloneCWrappers.powerpc64le.dir/wrappers_c.cpp.o
16.248 [24/16/490] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXrayBASIC.powerpc64le.dir/xray_basic_logging.cpp.o
16.479 [24/15/491] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXrayPROFILING.powerpc64le.dir/xray_profile_collector.cpp.o
16.977 [24/14/492] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-powerpc64le.dir/tsan_rtl_access.cpp.o
17.019 [24/13/493] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXrayPROFILING.powerpc64le.dir/xray_profiling.cpp.o
17.209 [24/12/494] Building CXX object compiler-rt/lib/orc/CMakeFiles/RTOrc.powerpc64le.dir/run_program_wrapper.cpp.o
17.324 [24/11/495] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-dynamic-powerpc64le.dir/tsan_rtl_access.cpp.o
17.400 [24/10/496] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/RTScudoStandaloneCxxWrappers.powerpc64le.dir/wrappers_cpp.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/90959