[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

Fri Oct 11 03:53:42 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `bolt-x86_64-ubuntu-clang` running on `bolt-worker` while building `clang,compiler-rt` at step 6 "test-build-clang-bolt-stage2-clang-bolt".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/113/builds/3322

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (test-build-clang-bolt-stage2-clang-bolt) failure: test (failure)
...
18.823 [125/18/1978] Building C object compiler-rt/lib/profile/CMakeFiles/clang_rt.profile-x86_64.dir/InstrProfilingPlatformLinux.c.o
18.827 [124/18/1979] Building C object compiler-rt/lib/profile/CMakeFiles/clang_rt.profile-x86_64.dir/InstrProfilingWriter.c.o
18.841 [123/18/1980] Building C object compiler-rt/lib/profile/CMakeFiles/clang_rt.profile-x86_64.dir/InstrProfilingFile.c.o
18.852 [122/18/1981] Building C object compiler-rt/lib/profile/CMakeFiles/clang_rt.profile-x86_64.dir/InstrProfilingUtil.c.o
18.862 [121/18/1982] Building CXX object compiler-rt/lib/nsan/CMakeFiles/RTNsan.x86_64.dir/nsan_allocator.cpp.o
18.863 [120/18/1983] Linking CXX static library compiler-rt/lib/ctx_profile/tests/libRTCtxProfileTest.x86_64.a
18.879 [119/18/1984] Linking CXX static library /home/worker/bolt-worker2/bolt-x86_64-ubuntu-clang/build/lib/clang/20/lib/x86_64-unknown-linux-gnu/libclang_rt.profile.a
18.910 [118/18/1985] Linking CXX static library /home/worker/bolt-worker2/bolt-x86_64-ubuntu-clang/build/lib/clang/20/lib/x86_64-unknown-linux-gnu/libclang_rt.nsan.a
18.931 [117/18/1986] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_flags.cpp.o
18.947 [116/18/1987] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_interface.cpp.o
FAILED: compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_interface.cpp.o 
/home/worker/bolt-worker2/bolt-x86_64-ubuntu-clang/build/./bin/clang++ --target=x86_64-unknown-linux-gnu -DSANITIZER_COMMON_NO_REDEFINE_BUILTINS -DXRAY_HAS_EXCEPTIONS=1 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/worker/bolt-worker2/bolt-x86_64-ubuntu-clang/llvm-project/compiler-rt/lib/xray/.. -I/home/worker/bolt-worker2/bolt-x86_64-ubuntu-clang/llvm-project/compiler-rt/lib/xray/../../include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wall -Wno-unused-parameter -O3 -DNDEBUG -m64 -fPIC -fno-builtin -fno-exceptions -fomit-frame-pointer -funwind-tables -fno-stack-protector -fno-sanitize=safe-stack -fvisibility=hidden -fno-lto -Wthread-safety -Wthread-safety-reference -Wthread-safety-beta -O3 -gline-tables-only -Wno-gnu -Wno-variadic-macros -Wno-c99-extensions -ftrivial-auto-var-init=pattern -Wno-format -fno-rtti -std=c++17 -MD -MT compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_interface.cpp.o -MF compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_interface.cpp.o.d -o compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_interface.cpp.o -c /home/worker/bolt-worker2/bolt-x86_64-ubuntu-clang/llvm-project/compiler-rt/lib/xray/xray_interface.cpp
/home/worker/bolt-worker2/bolt-x86_64-ubuntu-clang/llvm-project/compiler-rt/lib/xray/xray_interface.cpp:16:10: fatal error: 'llvm/Support/ErrorHandling.h' file not found
   16 | #include "llvm/Support/ErrorHandling.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
18.971 [116/17/1988] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_init.cpp.o
/home/worker/bolt-worker2/bolt-x86_64-ubuntu-clang/llvm-project/compiler-rt/lib/xray/xray_init.cpp:213:27: warning: comparison of integers of different signs: 'int32_t' (aka 'int') and 'size_t' (aka 'unsigned long') [-Wsign-compare]
  213 |   if (ObjId <= 0 || ObjId >= __xray_num_objects()) {
      |                     ~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~
1 warning generated.
18.989 [116/16/1989] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_log_interface.cpp.o
18.996 [116/15/1990] Building ASM object compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_trampoline_x86_64.S.o
19.005 [116/14/1991] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/RTScudoStandaloneCWrappers.x86_64.dir/wrappers_c.cpp.o
19.007 [116/13/1992] Generating version list for clang_rt.nsan-dynamic-x86_64
19.033 [116/12/1993] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/clang_rt.scudo_standalone-dynamic-x86_64.dir/wrappers_cpp.cpp.o
19.079 [116/11/1994] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_buffer_queue.cpp.o
19.087 [116/10/1995] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/clang_rt.scudo_standalone-x86_64.dir/wrappers_c.cpp.o
19.115 [116/9/1996] Building CXX object compiler-rt/lib/ctx_profile/CMakeFiles/clang_rt.ctx_profile-x86_64.dir/CtxInstrProfiling.cpp.o
19.175 [116/8/1997] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_utils.cpp.o
19.242 [116/7/1998] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_x86_64.cpp.o
19.269 [116/6/1999] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/clang_rt.scudo_standalone-dynamic-x86_64.dir/wrappers_c.cpp.o
21.834 [116/5/2000] Building CXX object compiler-rt/lib/msan/CMakeFiles/clang_rt.msan-x86_64.dir/msan_interceptors.cpp.o
22.357 [116/4/2001] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-x86_64.dir/tsan_interceptors_posix.cpp.o
23.127 [116/3/2002] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-dynamic-x86_64.dir/tsan_interceptors_posix.cpp.o
23.542 [116/2/2003] Building CXX object compiler-rt/lib/asan/CMakeFiles/RTAsan_dynamic.x86_64.dir/asan_interceptors.cpp.o
23.846 [116/1/2004] Building CXX object compiler-rt/lib/asan/CMakeFiles/RTAsan.x86_64.dir/asan_interceptors.cpp.o
ninja: build stopped: subcommand failed.
FAILED: runtimes/runtimes-stamps/runtimes-build /home/worker/bolt-worker2/bolt-x86_64-ubuntu-clang/build/runtimes/runtimes-stamps/runtimes-build 
cd /home/worker/bolt-worker2/bolt-x86_64-ubuntu-clang/build/runtimes/runtimes-bins && /usr/bin/cmake --build .
ninja: build stopped: subcommand failed.

```

</details>

https://github.com/llvm/llvm-project/pull/90959