[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

Fri Oct 11 02:39:32 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `openmp-offload-sles-build-only` running on `rocm-worker-hw-04-sles` while building `clang,compiler-rt` at step 5 "compile-openmp".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/140/builds/8563

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (compile-openmp) failure: build (failure)
...
4.749 [1061/34/644] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_init.cpp.o
/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/compiler-rt/lib/xray/xray_init.cpp:213:27: warning: comparison of integers of different signs: 'int32_t' (aka 'int') and 'size_t' (aka 'unsigned long') [-Wsign-compare]
  213 |   if (ObjId <= 0 || ObjId >= __xray_num_objects()) {
      |                     ~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~
1 warning generated.
4.752 [1060/34/645] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXrayPROFILING.x86_64.dir/xray_profiling_flags.cpp.o
4.761 [1059/34/646] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_log_interface.cpp.o
4.762 [1058/34/647] Building CXX object compiler-rt/lib/fuzzer/CMakeFiles/RTfuzzer.x86_64.dir/FuzzerExtFunctionsDlsym.cpp.o
4.763 [1057/34/648] Building CXX object compiler-rt/lib/fuzzer/CMakeFiles/RTfuzzer.x86_64.dir/FuzzerExtFunctionsWindows.cpp.o
4.766 [1056/34/649] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_interface.cpp.o
FAILED: compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_interface.cpp.o 
/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.build/./bin/clang++ --target=x86_64-unknown-linux-gnu -DSANITIZER_COMMON_NO_REDEFINE_BUILTINS -DXRAY_HAS_EXCEPTIONS=1 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/compiler-rt/lib/xray/.. -I/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/compiler-rt/lib/xray/../../include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wall -Wno-unused-parameter -O3 -DNDEBUG -m64 -fPIC -fno-builtin -fno-exceptions -fomit-frame-pointer -funwind-tables -fno-stack-protector -fno-sanitize=safe-stack -fvisibility=hidden -fno-lto -Wthread-safety -Wthread-safety-reference -Wthread-safety-beta -O3 -gline-tables-only -Wno-gnu -Wno-variadic-macros -Wno-c99-extensions -ftrivial-auto-var-init=pattern -Wno-format -fno-rtti -std=c++17 -MD -MT compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_interface.cpp.o -MF compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_interface.cpp.o.d -o compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_interface.cpp.o -c /home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/compiler-rt/lib/xray/xray_interface.cpp
/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/compiler-rt/lib/xray/xray_interface.cpp:16:10: fatal error: 'llvm/Support/ErrorHandling.h' file not found
   16 | #include "llvm/Support/ErrorHandling.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
4.772 [1056/33/650] Linking CXX static library /home/botworker/bbot/builds/openmp-offload-sles-build/llvm.build/lib/clang/20/lib/x86_64-unknown-linux-gnu/libclang_rt.xray-dso.a
4.780 [1056/32/651] Building CXX object compiler-rt/lib/fuzzer/CMakeFiles/RTfuzzer.x86_64.dir/FuzzerExtraCountersDarwin.cpp.o
4.787 [1056/31/652] Building CXX object compiler-rt/lib/fuzzer/CMakeFiles/RTfuzzer.x86_64.dir/FuzzerExtraCounters.cpp.o
4.788 [1056/30/653] Building CXX object compiler-rt/lib/fuzzer/CMakeFiles/RTfuzzer.x86_64.dir/FuzzerExtraCountersWindows.cpp.o
4.791 [1056/29/654] Building CXX object compiler-rt/lib/nsan/CMakeFiles/RTNsan.x86_64.dir/nsan.cpp.o
4.889 [1056/28/655] Building CXX object compiler-rt/lib/nsan/CMakeFiles/RTNsan_dynamic.x86_64.dir/nsan_allocator.cpp.o
4.900 [1056/27/656] Building CXX object compiler-rt/lib/ctx_profile/CMakeFiles/clang_rt.ctx_profile-x86_64.dir/CtxInstrProfiling.cpp.o
4.945 [1056/26/657] Building CXX object compiler-rt/lib/nsan/CMakeFiles/RTNsan.x86_64.dir/nsan_allocator.cpp.o
4.983 [1056/25/658] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXrayBASIC.x86_64.dir/xray_basic_logging.cpp.o
4.986 [1056/24/659] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_buffer_queue.cpp.o
5.101 [1056/23/660] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_utils.cpp.o
5.180 [1056/22/661] Building CXX object compiler-rt/lib/fuzzer/CMakeFiles/RTfuzzer_main.x86_64.dir/FuzzerMain.cpp.o
5.216 [1056/21/662] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_x86_64.cpp.o
5.266 [1056/20/663] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/RTScudoStandaloneCxxWrappers.x86_64.dir/wrappers_cpp.cpp.o
5.266 [1056/19/664] Building CXX object compiler-rt/lib/fuzzer/CMakeFiles/RTfuzzer.x86_64.dir/FuzzerExtFunctionsWeak.cpp.o
5.367 [1056/18/665] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/clang_rt.scudo_standalone-dynamic-x86_64.dir/wrappers_cpp.cpp.o
5.377 [1056/17/666] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/clang_rt.scudo_standalone_cxx-x86_64.dir/wrappers_cpp.cpp.o
5.399 [1056/16/667] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXrayPROFILING.x86_64.dir/xray_profiling.cpp.o
5.472 [1056/15/668] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXrayPROFILING.x86_64.dir/xray_profile_collector.cpp.o
5.506 [1056/14/669] Building CXX object compiler-rt/lib/fuzzer/CMakeFiles/RTfuzzer.x86_64.dir/FuzzerCrossOver.cpp.o
5.619 [1056/13/670] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/RTScudoStandaloneCWrappers.x86_64.dir/wrappers_c.cpp.o
5.652 [1056/12/671] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/clang_rt.scudo_standalone-dynamic-x86_64.dir/wrappers_c.cpp.o
5.709 [1056/11/672] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/clang_rt.scudo_standalone-x86_64.dir/wrappers_c.cpp.o
5.719 [1056/10/673] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXrayFDR.x86_64.dir/xray_fdr_logging.cpp.o
5.734 [1056/9/674] Building CXX object compiler-rt/lib/fuzzer/CMakeFiles/RTfuzzer.x86_64.dir/FuzzerIO.cpp.o
6.493 [1056/8/675] Building CXX object compiler-rt/lib/fuzzer/CMakeFiles/RTfuzzer.x86_64.dir/FuzzerDataFlowTrace.cpp.o
7.249 [1056/7/676] Building CXX object compiler-rt/lib/fuzzer/CMakeFiles/RTfuzzer.x86_64.dir/FuzzerDriver.cpp.o
7.391 [1056/6/677] Building CXX object compiler-rt/lib/fuzzer/CMakeFiles/RTfuzzer.x86_64.dir/FuzzerFork.cpp.o
9.383 [1056/5/678] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-x86_64.dir/tsan_interceptors_posix.cpp.o
9.489 [1056/4/679] Building CXX object compiler-rt/lib/msan/CMakeFiles/clang_rt.msan-x86_64.dir/msan_interceptors.cpp.o
9.635 [1056/3/680] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-dynamic-x86_64.dir/tsan_interceptors_posix.cpp.o
11.680 [1056/2/681] Building CXX object compiler-rt/lib/asan/CMakeFiles/RTAsan_dynamic.x86_64.dir/asan_interceptors.cpp.o
11.811 [1056/1/682] Building CXX object compiler-rt/lib/asan/CMakeFiles/RTAsan.x86_64.dir/asan_interceptors.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/90959