[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

Fri Oct 11 02:43:19 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `premerge-monolithic-linux` running on `premerge-linux-1` while building `clang,compiler-rt` at step 6 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/builds/11565

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (build-unified-tree) failure: build (failure)
...
11.487 [72/58/1366] Linking CXX shared library /build/buildbot/premerge-monolithic-linux/build/lib/clang/20/lib/x86_64-unknown-linux-gnu/libclang_rt.ubsan_minimal.so
11.500 [71/58/1367] Building CXX object compiler-rt/lib/nsan/CMakeFiles/RTNsan_dynamic.x86_64.dir/nsan_stats.cpp.o
11.500 [70/58/1368] Linking CXX static library /build/buildbot/premerge-monolithic-linux/build/lib/clang/20/lib/x86_64-unknown-linux-gnu/libclang_rt.hwasan.a
11.504 [69/58/1369] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-x86_64.dir/tsan_rtl_access.cpp.o
11.522 [68/58/1370] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXrayPROFILING.x86_64.dir/xray_profiling_flags.cpp.o
11.523 [67/58/1371] Linking CXX static library /build/buildbot/premerge-monolithic-linux/build/lib/clang/20/lib/x86_64-unknown-linux-gnu/libclang_rt.profile.a
11.541 [66/58/1372] Generating exported symbols for clang_rt.ubsan_minimal-x86_64
11.550 [65/58/1373] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXrayDSO.x86_64.dir/xray_dso_init.cpp.o
11.553 [64/58/1374] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_log_interface.cpp.o
11.562 [63/58/1375] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_interface.cpp.o
FAILED: compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_interface.cpp.o 
/build/buildbot/premerge-monolithic-linux/build/./bin/clang++ --target=x86_64-unknown-linux-gnu -DSANITIZER_COMMON_NO_REDEFINE_BUILTINS -DXRAY_HAS_EXCEPTIONS=1 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/build/buildbot/premerge-monolithic-linux/llvm-project/compiler-rt/lib/xray/.. -I/build/buildbot/premerge-monolithic-linux/llvm-project/compiler-rt/lib/xray/../../include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wall -Wno-unused-parameter -O3 -DNDEBUG -m64 -fPIC -fno-builtin -fno-exceptions -fomit-frame-pointer -funwind-tables -fno-stack-protector -fno-sanitize=safe-stack -fvisibility=hidden -fno-lto -Wthread-safety -Wthread-safety-reference -Wthread-safety-beta -O3 -gline-tables-only -Wno-gnu -Wno-variadic-macros -Wno-c99-extensions -ftrivial-auto-var-init=pattern -Wno-format -fno-rtti -std=c++17 -MD -MT compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_interface.cpp.o -MF compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_interface.cpp.o.d -o compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_interface.cpp.o -c /build/buildbot/premerge-monolithic-linux/llvm-project/compiler-rt/lib/xray/xray_interface.cpp
/build/buildbot/premerge-monolithic-linux/llvm-project/compiler-rt/lib/xray/xray_interface.cpp:16:10: fatal error: 'llvm/Support/ErrorHandling.h' file not found
   16 | #include "llvm/Support/ErrorHandling.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
11.563 [63/57/1376] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_init.cpp.o
/build/buildbot/premerge-monolithic-linux/llvm-project/compiler-rt/lib/xray/xray_init.cpp:213:27: warning: comparison of integers of different signs: 'int32_t' (aka 'int') and 'size_t' (aka 'unsigned long') [-Wsign-compare]
  213 |   if (ObjId <= 0 || ObjId >= __xray_num_objects()) {
      |                     ~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~
1 warning generated.
11.563 [63/56/1377] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-dynamic-x86_64.dir/tsan_rtl_report.cpp.o
11.572 [63/55/1378] Building CXX object compiler-rt/lib/nsan/CMakeFiles/RTNsan_dynamic.x86_64.dir/nsan.cpp.o
11.592 [63/54/1379] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof_dynamic.x86_64.dir/memprof_shadow_setup.cpp.o
11.612 [63/53/1380] Generating version list for clang_rt.hwasan-dynamic-x86_64
11.633 [63/52/1381] Generating exported symbols for clang_rt.hwasan-x86_64
11.648 [63/51/1382] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof_dynamic.x86_64.dir/memprof_descriptions.cpp.o
11.650 [63/50/1383] Building ASM object compiler-rt/lib/xray/CMakeFiles/RTXrayDSO.x86_64.dir/xray_trampoline_x86_64.S.o
11.675 [63/49/1384] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof_dynamic.x86_64.dir/memprof_flags.cpp.o
11.686 [63/48/1385] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof_dynamic.x86_64.dir/memprof_posix.cpp.o
11.688 [63/47/1386] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof_dynamic.x86_64.dir/memprof_stack.cpp.o
11.704 [63/46/1387] Building CXX object compiler-rt/lib/nsan/CMakeFiles/RTNsan.x86_64.dir/nsan.cpp.o
11.726 [63/45/1388] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof_dynamic.x86_64.dir/memprof_linux.cpp.o
11.726 [63/44/1389] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-dynamic-x86_64.dir/tsan_interface_atomic.cpp.o
11.733 [63/43/1390] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof.x86_64.dir/memprof_flags.cpp.o
11.751 [63/42/1391] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof_dynamic.x86_64.dir/memprof_thread.cpp.o
11.752 [63/41/1392] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof_dynamic.x86_64.dir/memprof_mibmap.cpp.o
11.760 [63/40/1393] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof.x86_64.dir/memprof_descriptions.cpp.o
11.773 [63/39/1394] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof_dynamic.x86_64.dir/memprof_rtl.cpp.o
11.780 [63/38/1395] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXrayBASIC.x86_64.dir/xray_basic_logging.cpp.o
11.785 [63/37/1396] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof_dynamic.x86_64.dir/memprof_malloc_linux.cpp.o
11.786 [63/36/1397] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof.x86_64.dir/memprof_linux.cpp.o
11.794 [63/35/1398] Building CXX object compiler-rt/lib/nsan/CMakeFiles/RTNsan.x86_64.dir/nsan_allocator.cpp.o
11.800 [63/34/1399] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof.x86_64.dir/memprof_malloc_linux.cpp.o
11.800 [63/33/1400] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof_dynamic.x86_64.dir/memprof_stats.cpp.o
11.804 [63/32/1401] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof_dynamic.x86_64.dir/memprof_new_delete.cpp.o
11.811 [63/31/1402] Building CXX object compiler-rt/lib/ctx_profile/CMakeFiles/clang_rt.ctx_profile-x86_64.dir/CtxInstrProfiling.cpp.o
11.817 [63/30/1403] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof.x86_64.dir/memprof_interceptors_memintrinsics.cpp.o
11.825 [63/29/1404] Building CXX object compiler-rt/lib/hwasan/CMakeFiles/RTHwasan_dynamic.x86_64.dir/hwasan_interceptors.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/90959