[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

Fri Oct 11 02:35:39 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `clang-cmake-x86_64-avx512-linux` running on `avx512-intel64` while building `clang,compiler-rt` at step 6 "build stage 1".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/133/builds/5059

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (build stage 1) failure: 'ninja' (failure)
...
[451/577] Building C object compiler-rt/lib/profile/CMakeFiles/clang_rt.profile-i386.dir/InstrProfilingFile.c.o
[452/577] Building C object compiler-rt/lib/profile/CMakeFiles/clang_rt.profile-x86_64.dir/GCDAProfiling.c.o
[453/577] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonNoHooks.i386.dir/sanitizer_libc.cpp.o
[454/577] Building CXX object compiler-rt/lib/fuzzer/CMakeFiles/RTfuzzer.i386.dir/FuzzerUtilWindows.cpp.o
[455/577] Linking CXX static library /localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/stage1/lib/clang/20/lib/i386-unknown-linux-gnu/libclang_rt.fuzzer_interceptors.a
[456/577] Building C object compiler-rt/lib/profile/CMakeFiles/clang_rt.profile-x86_64.dir/InstrProfilingValue.c.o
[457/577] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizer.i386.dir/sanitizer_symbolizer_report.cpp.o
[458/577] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_log_interface.cpp.o
[459/577] Building CXX object compiler-rt/lib/fuzzer/CMakeFiles/RTfuzzer_interceptors.x86_64.dir/FuzzerInterceptors.cpp.o
[460/577] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_interface.cpp.o
FAILED: compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_interface.cpp.o 
/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/stage1/./bin/clang++ --target=x86_64-unknown-linux-gnu -DSANITIZER_COMMON_NO_REDEFINE_BUILTINS -DXRAY_HAS_EXCEPTIONS=1 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/compiler-rt/lib/xray/.. -I/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/compiler-rt/lib/xray/../../include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wall -Wno-unused-parameter -O3 -DNDEBUG -m64 -fPIC -fno-builtin -fno-exceptions -fomit-frame-pointer -funwind-tables -fno-stack-protector -fno-sanitize=safe-stack -fvisibility=hidden -fno-lto -Wthread-safety -Wthread-safety-reference -Wthread-safety-beta -O3 -gline-tables-only -Wno-gnu -Wno-variadic-macros -Wno-c99-extensions -ftrivial-auto-var-init=pattern -Wno-format -fno-rtti -std=c++17 -MD -MT compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_interface.cpp.o -MF compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_interface.cpp.o.d -o compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_interface.cpp.o -c /localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/compiler-rt/lib/xray/xray_interface.cpp
/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/compiler-rt/lib/xray/xray_interface.cpp:16:10: fatal error: 'llvm/Support/ErrorHandling.h' file not found
   16 | #include "llvm/Support/ErrorHandling.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
[461/577] Building C object compiler-rt/lib/profile/CMakeFiles/clang_rt.profile-x86_64.dir/InstrProfilingFile.c.o
[462/577] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_init.cpp.o
/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/compiler-rt/lib/xray/xray_init.cpp:213:27: warning: comparison of integers of different signs: 'int32_t' (aka 'int') and 'size_t' (aka 'unsigned long') [-Wsign-compare]
  213 |   if (ObjId <= 0 || ObjId >= __xray_num_objects()) {
      |                     ~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~
1 warning generated.
[463/577] Linking CXX static library /localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/stage1/lib/clang/20/lib/i386-unknown-linux-gnu/libclang_rt.profile.a
[464/577] Linking CXX static library /localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/stage1/lib/clang/20/lib/x86_64-unknown-linux-gnu/libclang_rt.fuzzer_interceptors.a
[465/577] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonNoHooks.i386.dir/sanitizer_linux.cpp.o
[466/577] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonNoHooks.i386.dir/sanitizer_deadlock_detector1.cpp.o
[467/577] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizer.i386.dir/sanitizer_symbolizer_posix_libcdep.cpp.o
[468/577] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof.x86_64.dir/memprof_shadow_setup.cpp.o
[469/577] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof.x86_64.dir/memprof_flags.cpp.o
[470/577] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonNoHooks.i386.dir/sanitizer_thread_registry.cpp.o
[471/577] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizer.i386.dir/sanitizer_symbolizer_libcdep.cpp.o
[472/577] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof.x86_64.dir/memprof_posix.cpp.o
[473/577] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof.x86_64.dir/memprof_interceptors_memintrinsics.cpp.o
[474/577] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof.x86_64.dir/memprof_descriptions.cpp.o
[475/577] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommon.i386.dir/sanitizer_thread_registry.cpp.o
[476/577] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof.x86_64.dir/memprof_stack.cpp.o
[477/577] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof.x86_64.dir/memprof_linux.cpp.o
[478/577] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof.x86_64.dir/memprof_mibmap.cpp.o
[479/577] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXrayBASIC.x86_64.dir/xray_basic_logging.cpp.o
[480/577] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizer.i386.dir/sanitizer_stack_store.cpp.o
[481/577] Building CXX object compiler-rt/lib/ctx_profile/CMakeFiles/clang_rt.ctx_profile-x86_64.dir/CtxInstrProfiling.cpp.o
[482/577] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof.x86_64.dir/memprof_rtl.cpp.o
[483/577] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_buffer_queue.cpp.o
[484/577] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof.x86_64.dir/memprof_malloc_linux.cpp.o
[485/577] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof.x86_64.dir/memprof_rawprofile.cpp.o
[486/577] Building CXX object compiler-rt/lib/memprof/CMakeFiles/RTMemprof.x86_64.dir/memprof_stats.cpp.o
[487/577] Building CXX object compiler-rt/lib/fuzzer/CMakeFiles/RTfuzzer.x86_64.dir/FuzzerExtFunctionsWeak.cpp.o
[488/577] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_utils.cpp.o
[489/577] Building CXX object compiler-rt/lib/fuzzer/CMakeFiles/RTfuzzer_main.i386.dir/FuzzerMain.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/90959