[PATCH] D158820: [Sema][HLSL] Fix naming of anyhit/closesthit shaders

[Justin Bogner via Phabricator via cfe-commits]

bogner added inline comments.


================
Comment at: clang/test/SemaHLSL/shader_type_attr.hlsl:30
 
 // expected-error at +1 {{'shader' attribute parameters do not match the previous declaration}}
+[shader("pixel")]
----------------
bob80905 wrote:
> I don't think we should expect this error, given that there is no previous declaration for doubledUp(). Maybe something else like %0 and %1 are incompatible attributes? 
I don't necessarily disagree, but if we're going to change that I think it should be in a different change than this one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158820/new/

https://reviews.llvm.org/D158820