[PATCH] D158820: [Sema][HLSL] Fix naming of anyhit/closesthit shaders

Joshua Batista via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 25 10:27:28 PDT 2023


bob80905 added inline comments.


================
Comment at: clang/test/SemaHLSL/shader_type_attr.hlsl:30
 
 // expected-error at +1 {{'shader' attribute parameters do not match the previous declaration}}
+[shader("pixel")]
----------------
I don't think we should expect this error, given that there is no previous declaration for doubledUp(). Maybe something else like %0 and %1 are incompatible attributes? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158820/new/

https://reviews.llvm.org/D158820



More information about the cfe-commits mailing list