[PATCH] D155756: -fsanitize={function,kcfi}: Switch to xxh3_64bits

Sami Tolvanen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 19 15:06:59 PDT 2023


samitolvanen added a comment.

Changing the hash function breaks compatibility with the Rust KCFI implementation <https://github.com/rust-lang/rust/commit/947fe7e341c2c3c0bdb220fd31bb650ac24c7054#diff-93510af993182a7f62d69828651dc5c632304d8274ed03d5d77538c5597fcd84R23>. I would personally like to avoid changing how KCFI type hashes are computed unless there's a very compelling reason to switch away from xxHash64.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155756/new/

https://reviews.llvm.org/D155756



More information about the cfe-commits mailing list