[PATCH] D155756: -fsanitize={function,kcfi}: Switch to xxh3_64bits

Wed Jul 19 15:13:07 PDT 2023

MaskRay added a comment.

In D155756#4516501 <https://reviews.llvm.org/D155756#4516501>, @samitolvanen wrote:

> Changing the hash function breaks compatibility with the Rust KCFI implementation <https://github.com/rust-lang/rust/commit/947fe7e341c2c3c0bdb220fd31bb650ac24c7054#diff-93510af993182a7f62d69828651dc5c632304d8274ed03d5d77538c5597fcd84R23>. I would personally like to avoid changing how KCFI type hashes are computed unless there's a very compelling reason to switch away from xxHash64.

Thank you for the rapid reply. So this looks unfortunate, I'll change just -fsanitize=function then (the scheme was just changed a few months ago, not even across arelease; though sanitizers don't really commit to cross-version compatibility). Perhaps the only minor downside is that `xxHash64` is going to linger forever.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155756/new/

https://reviews.llvm.org/D155756