[PATCH] D155756: -fsanitize={function,kcfi}: Switch to xxh3_64bits

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 19 14:54:27 PDT 2023


MaskRay created this revision.
MaskRay added a reviewer: samitolvanen.
Herald added a project: All.
MaskRay requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Following recent changes switching from xxh64 to xxh32 for better
hashing performance (e.g., D154813 <https://reviews.llvm.org/D154813>). These particular instances likely
have negligible time, but this change moves us toward removing xxHash64.

The type hash for -fsanitize={function,kcfi} will change. This is
totally fine for =function, I assume that this is fine for =kcfi as well
as we cannot sign for compatibility across different Clang versions.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D155756

Files:
  clang/lib/CodeGen/CodeGenFunction.cpp
  clang/lib/CodeGen/CodeGenModule.cpp
  clang/test/CodeGen/kcfi-normalize.c
  clang/test/CodeGen/ubsan-function.cpp
  clang/test/CodeGenCXX/catch-undef-behavior.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155756.542207.patch
Type: text/x-patch
Size: 4605 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230719/e4597f01/attachment.bin>


More information about the cfe-commits mailing list