[PATCH] D155525: WIP
John McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jul 17 17:16:57 PDT 2023
rjmccall added inline comments.
================
Comment at: clang/lib/Sema/JumpDiagnostics.cpp:362
// it. This makes the second scan not have to walk the AST again.
+RecordJumpScope:
LabelAndGotoScopes[S] = ParentScope;
----------------
I would indent this at the same level as the `case` labels, and group it with them, too, but yeah, this is what I was thinking. But the helper function approach looks pretty clean, too. Your choice.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155525/new/
https://reviews.llvm.org/D155525
More information about the cfe-commits
mailing list