[PATCH] D155525: WIP
Nick Desaulniers via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jul 17 16:49:58 PDT 2023
nickdesaulniers created this revision.
Herald added a project: All.
nickdesaulniers requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Alternate to D155522 <https://reviews.llvm.org/D155522> based on
https://reviews.llvm.org/D155342#4507805
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D155525
Files:
clang/lib/Sema/JumpDiagnostics.cpp
Index: clang/lib/Sema/JumpDiagnostics.cpp
===================================================================
--- clang/lib/Sema/JumpDiagnostics.cpp
+++ clang/lib/Sema/JumpDiagnostics.cpp
@@ -331,11 +331,8 @@
// operand (to avoid recording the address-of-label use), which
// works only because of the restricted set of expressions which
// we detect as constant targets.
- if (cast<IndirectGotoStmt>(S)->getConstantTarget()) {
- LabelAndGotoScopes[S] = ParentScope;
- Jumps.push_back(S);
- return;
- }
+ if (cast<IndirectGotoStmt>(S)->getConstantTarget())
+ goto RecordJumpScope;
LabelAndGotoScopes[S] = ParentScope;
IndirectJumps.push_back(S);
@@ -352,15 +349,17 @@
BuildScopeInformation(Var, ParentScope);
++StmtsToSkip;
}
- [[fallthrough]];
+ goto RecordJumpScope;
- case Stmt::GotoStmtClass:
case Stmt::GCCAsmStmtClass:
- if (auto *GS = dyn_cast<GCCAsmStmt>(S))
- if (!GS->isAsmGoto())
- break;
+ if (!cast<GCCAsmStmt>(S)->isAsmGoto())
+ break;
+ goto RecordJumpScope;
+
+ case Stmt::GotoStmtClass:
// Remember both what scope a goto is in as well as the fact that we have
// it. This makes the second scan not have to walk the AST again.
+RecordJumpScope:
LabelAndGotoScopes[S] = ParentScope;
Jumps.push_back(S);
break;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155525.541267.patch
Type: text/x-patch
Size: 1366 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230717/7ecad3cd/attachment.bin>
More information about the cfe-commits
mailing list