[PATCH] D155525: WIP

[Nick Desaulniers via Phabricator via cfe-commits]

nickdesaulniers abandoned this revision.
nickdesaulniers added inline comments.


================
Comment at: clang/lib/Sema/JumpDiagnostics.cpp:362
     // it.  This makes the second scan not have to walk the AST again.
+RecordJumpScope:
     LabelAndGotoScopes[S] = ParentScope;
----------------
rjmccall wrote:
> I would indent this at the same level as the `case` labels, and group it with them, too, but yeah, this is what I was thinking.  But the helper function approach looks pretty clean, too.  Your choice.
I don't feel strongly either way. I'll fix up the indentation then squash this down into D155342; this is fewer lines changed than D155522.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155525/new/

https://reviews.llvm.org/D155525