[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

Jonas Hahnfeld via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 16 04:02:49 PDT 2023


Hahnfeld added a comment.

> We can't say this abstractly. It should be fine to work in ODRHash for C++20 modules issues as long as we don't lose informations.

I honestly don't understand this: For the approach to work, we would need to hash the two cases of an unqualified and a qualified template to the same value. You oppose to this approach because it would lose information. I can only conclude that the approach doesn't work with `ODRHash`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153003/new/

https://reviews.llvm.org/D153003



More information about the cfe-commits mailing list