[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

Fri Jun 16 19:12:54 PDT 2023

ChuanqiXu added a comment.

In D153003#4427731 <https://reviews.llvm.org/D153003#4427731>, @Hahnfeld wrote:

>> We can't say this abstractly. It should be fine to work in ODRHash for C++20 modules issues as long as we don't lose informations.
>
> I honestly don't understand this: For the approach to work, we would need to hash the two cases of an unqualified and a qualified template to the same value. You oppose to this approach because it would lose information. I can only conclude that the approach doesn't work with `ODRHash`.

I mean: **for this case** we couldn't solve it by ODRHash. But for **other** cases, it may be still good to solve the issues by improving ODRHash.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153003/new/

https://reviews.llvm.org/D153003