[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

Chuanqi Xu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 16 03:15:30 PDT 2023


ChuanqiXu added a comment.

> I was thinking to "solve" this by making them hash to the same value, but I'm hearing that using ODRHash for this purpose is the wrong approach to begin with?

We can't say this abstractly. It should be fine to work in ODRHash for C++20 modules issues as long as we don't lose informations. And this **was** the major issue of the patch. (**Now** the major issue is that the case shouldn't be accepted.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153003/new/

https://reviews.llvm.org/D153003



More information about the cfe-commits mailing list