[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

[Jonas Hahnfeld via Phabricator via cfe-commits]

Hahnfeld added a comment.

In D153003#4427412 <https://reviews.llvm.org/D153003#4427412>, @ChuanqiXu wrote:

> An important node here is that ODRHash is used to check the AST Nodes are keeping the same across compilations. There is gap to use ODRHash to check the semantical equality.

Oh ok... I'm coming from the context of https://reviews.llvm.org/D41416 which uses `ODRHash`es to decide which `Decl`s to load. The problem at hand is that the hash in the module was computed from a `TemplateName::Template` while the instantiating context has a fully qualified template name. I was thinking to "solve" this by making them hash to the same value, but I'm hearing that using `ODRHash` for this purpose is the wrong approach to begin with?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153003/new/

https://reviews.llvm.org/D153003