[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

Abel Bernabeu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 15 04:07:53 PDT 2023


abel-bernabeu added a comment.

For the customer who reported the problem, the comments are in the input source (doing their job explaining what the operands are).

Now, if that comment is not seen when compiling with "-S" it is less of a problem that having the compilation not succeeding. I did not see an obvious way to pass those coments to the AsmParser instance.

My understanding is that the ParseInstruction interface needs to be extended for the comments to be collected and passed to the top level parser (similarly to what is done with the operands).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153008/new/

https://reviews.llvm.org/D153008



More information about the cfe-commits mailing list