[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

[Roger Ferrer Ibanez via Phabricator via cfe-commits]

rogfer01 added a comment.

Hi @abel-bernabeu, I did a quick experiment replacing all the calls to `getLexer().Lex()` with `getParser().Lex()` and now your testcase is accepted and looks like this in the output

  f2:
  	addi	sp, sp, -32
  	sd	ra, 24(sp)
  	sd	s0, 16(sp)
  	addi	s0, sp, 32
  	#APP
  	lui	a0, 1	# this is fine 	# this should also be fine 
  	addiw	a0, a0, 564
  	add	zero, a0, a0
  
  	#NO_APP

I understand this is the best we can do within assembly syntax.

I'm not suggesting we should change all of them. There are ~20 occurrences of `getLexer.Lex()` so I think it should not be too onerous to review each one.

What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153008/new/

https://reviews.llvm.org/D153008