[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

David Spickett via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 15 03:59:14 PDT 2023


DavidSpickett added a reviewer: DavidSpickett.
DavidSpickett added a comment.

Is the comment here relevant? https://discourse.llvm.org/t/interleaving-several-c-style-comments-in-the-same-inline-assembly-line/71353/8 Does this patch do that already?

Also is it a problem that the ignored comments are not seen in the output? Perhaps you are just not checking for those bits. For comments on the end, those are propagated to the assembly output I know that much.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153008/new/

https://reviews.llvm.org/D153008



More information about the cfe-commits mailing list