[PATCH] D149579: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat May 6 13:05:49 PDT 2023


MaskRay added inline comments.


================
Comment at: llvm/test/MC/X86/intel-syntax-branch-fail.s:1
+// RUN: not llvm-mc -triple i686-unknown-unknown -x86-asm-syntax=intel %s 2>&1 | FileCheck %s
+
----------------
Don't create a separate test for negative tests. Use the `--defsym=ERR=1` and `.ifdef ERR` pattern to keep positive and negative tests in one file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149579/new/

https://reviews.llvm.org/D149579



More information about the cfe-commits mailing list