[PATCH] D149579: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat May 6 13:04:19 PDT 2023


MaskRay added inline comments.


================
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:2662
+    // TODO: Consider making the `call [offset fn_ref]` syntax an error?
+#if 0
+    if (!PtrInOperand && SM.isOffsetOperator())
----------------
I think this patch can be pushed now. 

Remove `#if 0` from this patch. Just add the lines in D150048.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149579/new/

https://reviews.llvm.org/D149579



More information about the cfe-commits mailing list