[PATCH] D149579: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat May 6 13:07:46 PDT 2023


MaskRay added inline comments.


================
Comment at: llvm/test/MC/X86/intel-syntax-branch-fail.s:5
+// call [offset fn_ref]
+// // TODO-CHECK: {{.*}}intel-syntax-branch-fail.s:[[#@LINE+-1]]:1: error: `OFFSET` operator cannot be used in an unconditional branch
+// jmp [offset fn_ref]
----------------
`[[#@LINE+-1]]` => `[[#@LINE-1]]`

Remove the file name `intel-syntax-branch-fail.s`.

I'd remove `TODO-CHECK` in this patch and add ``// CHECK: :[[#@LINE+-1]]:1: error: `OFFSET` operator cannot be used in an unconditional branch`` in D150048.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149579/new/

https://reviews.llvm.org/D149579



More information about the cfe-commits mailing list