[PATCH] D148458: [clang-tidy][NFC] Split bugprone-exception-escape tests

Piotr Zegar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 2 11:51:23 PDT 2023


PiotrZSL added a comment.

@isuckatcs 
Ifdefs are ugly, to avoid messing with multiple runs in same unit test, I decided to split into 2 test files (C++11 and above, and C++11,C++14).

And to be honest this change does nothing for caching (zero impact), let me explain:
`super_throws_again` alone won't be tested, because its not `noexcept`, it will be tested only once (no cache hit) when testing `sub_throws_again`.
Same goes for `throwing_throw_nothing`, its not called from anywhere, so there will be no hit into cache.

Simply code that were moved into new file didn't utilize cache before and now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148458/new/

https://reviews.llvm.org/D148458



More information about the cfe-commits mailing list