[PATCH] D148458: [clang-tidy][NFC] Split bugprone-exception-escape tests

Carlos Galvez via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun May 7 09:46:32 PDT 2023


carlosgalvezp accepted this revision.
carlosgalvezp added a comment.
This revision is now accepted and ready to land.

LGTM!

> A lot of our test files uses macros to differentiate between specific C++ standards, why not do that here too?

It's not that easy, because the #ifdef lines do not remove the `// CHECK` comments, so to work around that it gets messy very easily. Splitting into 2 files seems to be common practice in other tests for easier maintenance and readability.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148458/new/

https://reviews.llvm.org/D148458



More information about the cfe-commits mailing list