[PATCH] D148458: [clang-tidy][NFC] Split bugprone-exception-escape tests

Domján Dániel via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 2 11:36:09 PDT 2023


isuckatcs added a comment.

> Yes, throw specifier is removed in C++17, split allows to support C++17 and above in main test file

A lot of our test files uses macros to differentiate between specific C++ standards, why not do that here too?
There are only a few occurences of functions with `throw()`.

  #if __cplusplus  < 201703L
        // put functions with throw() here
  #endif



> Those tests never tested caching (not failing if you disable cache)

They weren't tested explicitly, but it still happened in the background by default.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148458/new/

https://reviews.llvm.org/D148458



More information about the cfe-commits mailing list