[PATCH] D146987: [Assignment Tracking] Enable by default

Thu Apr 13 02:35:36 PDT 2023

Orlando added a comment.

In D146987#4263263 <https://reviews.llvm.org/D146987#4263263>, @rupprecht wrote:

> In D146987#4263048 <https://reviews.llvm.org/D146987#4263048>, @MaskRay wrote:
>
>> The latest reland 3820e9a2b29a2e268319ed6635da0d59e18d736d <https://reviews.llvm.org/rG3820e9a2b29a2e268319ed6635da0d59e18d736d> still caused some issues to our internal workloads. Stay tuned...
>>
>> So far we have only found crashes with ThinLTO workloads.
>
> More specifically, thinlto + split debug.
>
> I'm not sure if my reduction is the same issue as @aeubanks has. Here's mine: F27123766: repro-D146987.ll <https://reviews.llvm.org/F27123766>
>
> Repro w/ `clang -O1 -c reduced.ll -o /dev/null`
>
> I don't see any assertions going off for this one. The stack trace I have just points to `llvm::Value::stripPointerCasts`. Lemme know if you need more info, but I'm hoping that file reproduces for you.

Thanks for this. This one has a similar cause to @aeubanks's issue but manifests differently. Fixed in D148204 <https://reviews.llvm.org/D148204>

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146987/new/

https://reviews.llvm.org/D146987