[PATCH] D146987: [Assignment Tracking] Enable by default

Thu Apr 13 03:02:58 PDT 2023

jmorse added a comment.

Many thanks for all the feedback,

In D146987#4263139 <https://reviews.llvm.org/D146987#4263139>, @aeubanks wrote:

> I'm seeing
>
>   llc: ../../llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:6214: void llvm::SelectionDAGBuilder::visitIntrinsicCall(const CallInst &, unsigned int): Assertion `AssignmentTrackingEnabled && "expected assignment tracking to be enabled"' failed.                                                                
>
> with this patch on the following IR (just run `llc` on it)
> F27123156: b.ll.txt <https://reviews.llvm.org/F27123156>

Hmmmm, that feels like a legitimate IR input where the configuration of debug-info / intrinsics is just unexpected -- we probably shouldn't assert in that situation but gracefully degrade to interpreting a dbg.assign as a dbg.value.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146987/new/

https://reviews.llvm.org/D146987