[PATCH] D146987: [Assignment Tracking] Enable by default

[Orlando Cazalet-Hyams via Phabricator via cfe-commits]

Orlando added a comment.

In D146987#4263139 <https://reviews.llvm.org/D146987#4263139>, @aeubanks wrote:

> I'm seeing
>
>   llc: ../../llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:6214: void llvm::SelectionDAGBuilder::visitIntrinsicCall(const CallInst &, unsigned int): Assertion `AssignmentTrackingEnabled && "expected assignment tracking to be enabled"' failed.                                                                
>
> with this patch on the following IR (just run `llc` on it)
> F27123156: b.ll.txt <https://reviews.llvm.org/F27123156>

This one is interesting... there's a `dbg.assign` (an assignment tracking debug intrinsic) there:

  define void @_ZN3gfx31PointTest_VectorArithmetic_Test8TestBodyEv() {
  entry:
    call void @llvm.dbg.assign(metadata i1 undef, metadata !204, metadata !DIExpression(), metadata !210, metadata ptr null, metadata !DIExpression()), !dbg !211
    ret void
  }

but the module flags don't contain the "assignment tracking is turned on" flag (`!{i32 7, !"debug-info-assignment-tracking", i1 true}`).

  !llvm.module.flags = !{!203}
  !203 = !{i32 2, !"Debug Info Version", i32 3}

If the reproducer below is the one used to create this one then I think the reduction process may have just cut the module flag. Do you know if you've hit this assertion from a source code reproducer?

In D146987#4263757 <https://reviews.llvm.org/D146987#4263757>, @aeubanks wrote:

> F27125556: a.tgz <https://reviews.llvm.org/F27125556>
>
> this is the original repro that crashed but maybe differently (you'll need to remove the plugin arguments since our clang has some custom plugins)

This is indeed a different issue to the first one - D148203 <https://reviews.llvm.org/D148203> fixes this one.

Thanks for these reproducers!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146987/new/

https://reviews.llvm.org/D146987