[PATCH] D146514: [clang][dataflow] Fix crash when RHS of `&&` or `||` calls `noreturn` func.

[Yitzhak Mandelbaum via Phabricator via cfe-commits]

ymandel accepted this revision.
ymandel added a comment.

Nice! Thank you.



================
Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:174-175
+      if (RHSVal == nullptr) {
+        // If the RHS isn't reachable, this implies that if we end up evaluating
+        // this BinaryOperator, the value of the LHS must have triggered the
+        // short-circuit logic. This implies that the value of the entire
----------------
nit. reworded (using A => B => C  is the same as A & B => C).  but, your call.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146514/new/

https://reviews.llvm.org/D146514