[PATCH] D146514: [clang][dataflow] Fix crash when RHS of `&&` or `||` calls `noreturn` func.
Martin Böhme via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 21 04:51:03 PDT 2023
mboehme marked an inline comment as done.
mboehme added inline comments.
================
Comment at: clang/include/clang/Analysis/FlowSensitive/ControlFlowContext.h:52
+ /// Returns whether `B` is reachable from the entry block.
+ bool isBlockReachable(const CFGBlock *B) const {
+ return BlockReachable[B->getBlockID()];
----------------
sgatev wrote:
> What do you think about making this a const reference? Alternatively, let's document that it must not be null?
Good point -- done!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146514/new/
https://reviews.llvm.org/D146514
More information about the cfe-commits
mailing list