[PATCH] D146514: [clang][dataflow] Fix crash when RHS of `&&` or `||` calls `noreturn` func.
Gábor Horváth via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 21 09:01:45 PDT 2023
xazax.hun added a comment.
This fix looks good for me for this particular problem, but I wonder whether the solution is general enough. In case the analysis figures out that a call would not return (e.g., the `value` method is called on a provably empty optional, and it would throw instead of returning), would this approach still work? Would the analysis update the `BlockReachable` bitvector on demand?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146514/new/
https://reviews.llvm.org/D146514
More information about the cfe-commits
mailing list