[PATCH] D145843: [clangd] Add option to always insert headers with <> instead of ""

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 20 11:49:13 PDT 2023


nridge added a comment.

My understanding is that a more elaborate configuration scheme has been proposed in https://github.com/clangd/clangd/issues/1367, and the feedback there was (quoting Sam from this comment <https://github.com/clangd/clangd/issues/1367#issuecomment-1322018307>):

> I think this design is very complicated for the value it provides. [...]
> For `<>` vs `""` in particular, we do have multiple reports suggesting this. I think we should be open to a either a **simple** config-based solution

The approach taken in this patch seemed to me to be in line with this direction of a "simple config-based solution".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145843/new/

https://reviews.llvm.org/D145843



More information about the cfe-commits mailing list