[PATCH] D145843: [clangd] Add option to always insert headers with <> instead of ""

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added a comment.

sorry but I am not sure what's the value proposed by this patch in its current form. in https://github.com/clangd/clangd/issues/1247 and other places we've discussed this, i believe the sentiment was towards providing a config option that'll let people customize header insertion style in combination with a directory filter, e.g:

  Style:
    IncludeInsertion:
        Directory: foo/
        Delimeter: <
     ... More IncludeInsertion customizations.

Any specific reasons for going with the hard-coded approach? As I don't think we can accept all this extra code to make sure it works for a "handful" projects/users (in the wild I haven't seen many projects that strictly use `<` includes). The use case you want can still be accommodated by such a generic approach, you can have `Directory: /` or we can even treat absence of `Directory` field as an "always" matcher.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145843/new/

https://reviews.llvm.org/D145843